From 4d8b3348f94b0cef5cbf9f4d26cfb113dcb50061 Mon Sep 17 00:00:00 2001
From: arjen <arjen>
Date: Fri, 21 Feb 2003 08:50:12 +0000
Subject: [PATCH] Database optimizations.

---
 src/web/log.php       | 21 ++++++++++++---------
 src/web/parameter.php | 15 +++++++++------
 2 files changed, 21 insertions(+), 15 deletions(-)

diff --git a/src/web/log.php b/src/web/log.php
index aa5ca97..9fcfe34 100644
--- a/src/web/log.php
+++ b/src/web/log.php
@@ -1,4 +1,4 @@
-<?php 
+<?php
 
 /**************************************************************************
 **  (c) Copyright 2003, Andromeda Technology & Automation
@@ -9,7 +9,7 @@
 ***********************
 **      FILE NAME      : log.php
 **      SYSTEM NAME    : Gnucomo - Gnu Computer Monitoring
-**      VERSION NUMBER : $Revision: 1.2 $
+**      VERSION NUMBER : $Revision: 1.3 $
 **
 **  DESCRIPTION      : Logs page
 **
@@ -21,13 +21,16 @@
 ********************************
 **      ORIGINAL AUTHOR : Arjen Baart - arjen@andromeda.nl
 **      CREATION DATE   : Dec 04, 2002
-**      LAST UPDATE     : Feb 08, 2003
+**      LAST UPDATE     : Feb 16, 2003
 **      MODIFICATIONS   : 
 **************************************************************************/
 
 /*****************************
    $Log: log.php,v $
-   Revision 1.2  2003-02-13 09:01:29  arjen
+   Revision 1.3  2003-02-21 08:50:12  arjen
+   Database optimizations.
+
+   Revision 1.2  2003/02/13 09:01:29  arjen
    All web interface pages use the page class.
 
    Revision 1.2  2003/02/05 09:48:14  arjen
@@ -35,7 +38,7 @@
 
 ******************************/
 
-// RCSID = "$Id: log.php,v 1.2 2003-02-13 09:01:29 arjen Exp $";
+// RCSID = "$Id: log.php,v 1.3 2003-02-21 08:50:12 arjen Exp $";
 
 ini_set('include_path', '.:./classes:../phpclasses');
 
@@ -49,20 +52,20 @@ class log_page extends page
    {
       if (!empty($_GET['oid']))
       {
-         $res = pg_exec($this->database, "SELECT objectname FROM object WHERE objectid=" . $_GET['oid']);
+         $res = pg_exec($this->database, "SELECT objectname FROM object WHERE objectid=CAST'" . $_GET['oid']. "' AS BIGINT)");
          $obj = pg_fetch_object($res, 0);
          echo "<h1>Log for " . $obj->objectname . "</h1><hr>";
 
          $res = pg_exec($this->database, "SELECT object_timestamp, servicecode, rawdata FROM log "
-                        ."WHERE objectid=" . $_GET['oid']);
-      
+                        ."WHERE objectid = CAST('" . $_GET['oid'] . "' AS BIGINT) ");
+
          echo "<table>";
          $row = 0;
          while ($row < pg_numrows($res))
          {
             $log = pg_fetch_object($res, $row);
             ?>
-            <tr><td align='center'>
+            <tr><td class='time'>
                <?php echo $log->object_timestamp?>
             </td><td>
                <?php echo $log->servicecode?>
diff --git a/src/web/parameter.php b/src/web/parameter.php
index 42a0e58..ce19381 100644
--- a/src/web/parameter.php
+++ b/src/web/parameter.php
@@ -9,7 +9,7 @@
 ***********************
 **      FILE NAME      : parameter.php
 **      SYSTEM NAME    : Gnucomo - Gnu Computer Monitoring
-**      VERSION NUMBER : $Revision: 1.3 $
+**      VERSION NUMBER : $Revision: 1.4 $
 **
 **  DESCRIPTION      : 
 **
@@ -27,7 +27,10 @@
 
 /*****************************
    $Log: parameter.php,v $
-   Revision 1.3  2003-02-13 09:01:29  arjen
+   Revision 1.4  2003-02-21 08:50:12  arjen
+   Database optimizations.
+
+   Revision 1.3  2003/02/13 09:01:29  arjen
    All web interface pages use the page class.
 
    Revision 1.2  2003/02/05 09:47:39  arjen
@@ -35,7 +38,7 @@
 
 ******************************/
 
-// RCSID = "$Id: parameter.php,v 1.3 2003-02-13 09:01:29 arjen Exp $";
+// RCSID = "$Id: parameter.php,v 1.4 2003-02-21 08:50:12 arjen Exp $";
 
 
 ini_set('include_path', '.:./classes:../phpclasses');
@@ -67,12 +70,12 @@ class param_page extends page
 
    if (!empty($_GET['oid']))
    {
-      $res = pg_exec($this->database, "SELECT objectname FROM object WHERE objectid=" . $_GET['oid']);
+      $res = pg_exec($this->database, "SELECT objectname FROM object WHERE objectid=CAST('" . $_GET['oid']."' AS BIGINT)");
       $obj = pg_fetch_object($res, 0);
       echo "<h1>Parameters for " . $obj->objectname . "</h1>";
 
       $res = pg_exec($this->database, "SELECT paramid, class, name, description FROM parameter "
-                     ."WHERE objectid=" . $_GET['oid'] . "order by class, name");
+                     ."WHERE objectid= CAST('" . $_GET['oid'] . "' AS BIGINT) order by class, name");
       
      ?>
      <form action='parameter_compare.php' method='post'>
@@ -101,7 +104,7 @@ class param_page extends page
          </td><td>
             <?php
                $r = pg_exec($this->database, "SELECT name, value FROM property
-                                              WHERE paramid='" . $par->paramid . "'");
+                                              WHERE paramid=CAST('" . $par->paramid . "' AS BIGINT)");
                for ($p = 0; $p < pg_numrows($r); $p++)
                {
                   $prop = pg_fetch_object($r, $p);
-- 
2.11.0